search

bugsnag / bugsnag-expo

MIT License
10 stars 5 forks source link

Support monorepo #147

Open ricardoribas opened 11 months ago

ricardoribas commented 11 months ago

Goal

When we setup bugsnag react native package, it doesn't support 100% monorepo. Apparently, the best option right now to support it is to perform hoisting on packages (if you are using yarn workspaces). The idea is to support a standalone package, but also monorepo.

Design

To better locate the bugsnag sourcemap package. When executing under the xcode build phases, the relative path will not work if we are working under monorepo projects. With this approach, the problem gets solved.

Changeset

  1. Created xcode build phase script to add the node_binary to the execution context.
  2. Changed the ios plugin to include the new build phase script
  3. Changed bash script to execute the bugsnag source maps binary regardless of the package location

Also refers to the bugsnag/source-maps package PR87

Testing

Right now i just tested on my project. I would need some guidance in order to test it properly and not affect other developers. Feedback is needed 😄

clr182 commented 10 months ago

Hi @ricardoribas Thank you for opening this pull request, I've added it to our backlog and like for your PR on our source-maps repo, one of our engineers will take a look when priorities allow.

ricardoribas commented 7 months ago

@clr182 do you have any update on this?

mclack commented 6 months ago

Hi @ricardoribas

We appreciate your patience here.

Unfortunately we don't have any updates on an ETA yet, but this remains on our backlog to be looked at when priorities allow.

We will make sure to post any updates here when they are available.