In case of different main files it's impossible to differentiate which main file the error came from.
Design
It's less invasive than correcting the order of trimming paths. (#211)
First trimming is performed for every package and it trims everything until the package name.
It's mostly for external packages or golang internal pkg.
Because main is a special package (pkg name is just "main" without module) we omit it in the first trimming.
Then if it's added to ProjectPackages and SourceRoot is properly configured the path will be trimmed properly.
So for input path: "/user/name/work/cmd/main.go"
current solution will provide: "main.go"
and this PR's solution will provide either "/user/name/work/cmd/main.go" or "cmd/main.go" depending of whether SourceRoot is configured.
Changeset
Skipped trimming path for "main" package.
Testing
Adjusted maze tests - for testcases that check main.go line numbers we setup SourceRoot so that main's path is trimmed correctly.
Goal
In case of different main files it's impossible to differentiate which main file the error came from.
Design
It's less invasive than correcting the order of trimming paths. (#211) First trimming is performed for every package and it trims everything until the package name. It's mostly for external packages or golang internal pkg. Because
mainis a special package (pkg name is just "main" without module) we omit it in the first trimming. Then if it's added to ProjectPackages and SourceRoot is properly configured the path will be trimmed properly. So for input path: "/user/name/work/cmd/main.go" current solution will provide: "main.go" and this PR's solution will provide either "/user/name/work/cmd/main.go" or "cmd/main.go" depending of whether SourceRoot is configured.Changeset
Skipped trimming path for "main" package.
Testing
Adjusted maze tests - for testcases that check
main.goline numbers we setupSourceRootso that main's path is trimmed correctly.