bugsnag / bugsnag-go

Automatic panic monitoring for Go and Go web frameworks, like negroni, gin, and revel
https://docs.bugsnag.com/platforms/go
MIT License
203 stars 69 forks source link

Rewrite maze runner tests from v1 to v9 #237

Closed DariaKunoichi closed 3 weeks ago

DariaKunoichi commented 4 weeks ago

Goal

Tests written on maze-runner v1 stopped working for newer github action's images.

Changeset

Merged three test apps into one, added command pattern, updated Dockerfile to use GO111MODULES.

Testing

Rewritten maze-runner tests.

twometresteve commented 3 weeks ago

I've raised a couple of basic comments, but the diff is far too complex and large for me to feel comfortable reviewing it effectively. There are also merge conflicts anyway to resolve.

Could the changes be reconstructed into a series of much smaller PRs into an integration branch, even if the tests don't all pass until the end of that integration branch?