search

bugsnag / bugsnag-js-performance

Monitor the performance of your JavaScript (web and React Native) and see the results in your BugSnag dashboard.
https://docs.bugsnag.com/performance/integration-guides
MIT License
5 stars 3 forks source link

Check requestEntropy methods are present in native module #386

Closed yousif-bugsnag closed 11 months ago

yousif-bugsnag commented 11 months ago

Goal

On iOS the codegen for turbo modules doesn't run unless you run pod install with RCT_NEW_ARCH_ENABLED=1, and there are no compiler warnings or errors when the native module spec has changed - any new native methods added since the last codegen are just undefined at runtime.

We should therefore ensure the new native methods requestEntropy and requestEntropyAsync are present (as well as the native module itself) before using them.

github-actions[bot] commented 11 months ago

Browser bundle size

NPM build

Package
Before 175.95 kB
After 175.95 kB
± No change

CDN build

Unminified Minfied Minified + gzipped
Before 84.94 kB 31.99 kB 9.84 kB
After 84.94 kB 31.99 kB 9.84 kB
± No change No change No change

Code coverage

Ok File (✨=New File) Lines Branches Functions Statements
🔴 /home/runner/work/bugsnag-js-performance/bugsnag-js-performance/packages/platforms/browser/lib/id-generator.ts 88.88%
(-11.12%)		 0%
(-100%)		 100%
(+0%)		 88.88%
(-11.12%)
🔴 /home/runner/work/bugsnag-js-performance/bugsnag-js-performance/packages/platforms/react-native/lib/id-generator.ts 100%
(+0%)		 100%
(+0%)		 88.88%
(+1.38%)		 97.14%
(+0.18%)

Total:

Lines Branches Functions Statements
92.14%(-0.06%) 80.91%(-0.08%) 93.89%(+0.02%) 90.18%(-0.05%)

Generated against 4eee708db8a52460bc6e824360cddd96c4c479b5 on 11 December 2023 at 17:24:50 UTC