Fix invalid span duration when ending immediately - Githubissues

bugsnag / bugsnag-js-performance

Monitor the performance of your JavaScript (web and React Native) and see the results in your BugSnag dashboard.

https://docs.bugsnag.com/performance/integration-guides

MIT License

4 stars 1 forks source link

Fix invalid span duration when ending immediately #396

Closed gingerbenw closed 5 months ago

gingerbenw commented 5 months ago

Goal

Ensure navigation spans are not ended with time of 0 when not using a CompleteNavigation component

Testing

github-actions[bot] commented 5 months ago

Browser bundle size

NPM build

	Package
Before	`178.36 kB`
After	`178.36 kB`
±	No change

CDN build

	Unminified	Minfied	Minified + gzipped
Before	`85.74 kB`	`32.30 kB`	`9.90 kB`
After	`85.74 kB`	`32.30 kB`	`9.90 kB`
±	No change	No change	No change

Code coverage

Ok	File (✨=New File)	Lines	Branches	Functions	Statements
🔴	/home/runner/work/bugsnag-js-performance/bugsnag-js-performance/packages/platforms/browser/lib/id-generator.ts	88.88% (-11.12%)	0% (-100%)	100% (+0%)	88.88% (-11.12%)

Total:

Lines	Branches	Functions	Statements
91.45%(-0.07%)	79.92%(-0.19%)	91.89%(+0%)	88.94%(-0.06%)

Generated against 2e02575bb6363f06b1dc3aba7ef0f02b5e61f20b on 22 January 2024 at 12:27:33 UTC