[PLAT-11567] Complete navigation component

bugsnag / bugsnag-js-performance

Monitor the performance of your JavaScript (web and React Native) and see the results in your BugSnag dashboard.

https://docs.bugsnag.com/performance/integration-guides

MIT License

4 stars 1 forks source link

[PLAT-11567] Complete navigation component #410

Closed gingerbenw closed 4 months ago

gingerbenw commented 4 months ago

Goal

Add CompleteNavigation component to make navigation spans more accurate

Design

Same pattern for component lifecycle methods as the @bugsnag/react-navigation plugin component, but leveraging the getPlugin method from BugsnagPerformance as we are not able to provide a wrapper component and leverage context to have a single point of reference for number of mounted components and the state of the current navigation span

Changeset

Added new component
Updated plugin implementation to end spans depending on the number of components waiting
Added bugsnag.navigation.ended_by span attribute

Testing

Unit tests for the NavigationComplete component
Unit test that the plugin handles awaiting components and updating span attributes correctly
Update end to end test to instrument NavigationComplete component (there is currently a bug on iOS, so the assertion for the ended_by span attribute is currently loose and will be improved in a separate ticket as this affects both plugins)

github-actions[bot] commented 4 months ago

Browser bundle size

NPM build

	Package
Before	`180.09 kB`
After	`180.09 kB`
±	No change

CDN build

	Unminified	Minfied	Minified + gzipped
Before	`87.01 kB`	`32.72 kB`	`10.01 kB`
After	`87.01 kB`	`32.72 kB`	`10.01 kB`
±	No change	No change	No change

Code coverage

Ok	File (✨=New File)	Lines	Branches	Functions	Statements
✅	/home/runner/work/bugsnag-js-performance/bugsnag-js-performance/packages/platforms/browser/lib/id-generator.ts	100% (+11.12%)	100% (+100%)	100% (+0%)	100% (+11.12%)

Total:

Lines	Branches	Functions	Statements
87.5%(-1.6%)	78.82%(-1.49%)	88.34%(-1.04%)	84.38%(-2%)

Generated against b7b83c9885731fc61325b416220786147d995447 on 28 February 2024 at 17:52:23 UTC