[PLAT-11664] Refactor navigation components - Githubissues

bugsnag / bugsnag-js-performance

Monitor the performance of your JavaScript (web and React Native) and see the results in your BugSnag dashboard.

https://docs.bugsnag.com/performance/integration-guides

MIT License

4 stars 1 forks source link

[PLAT-11664] Refactor navigation components #418

Closed gingerbenw closed 3 months ago

gingerbenw commented 4 months ago

Goal

Ensure the CompleteNavigation interacts with navigation spans as intended

Changeset

Refactor complete-navigation.tsx to use a functional component
use componentWillAppear over componentDidAppear listener to prevent iOS issues when using the CompleteNavigation component

Testing

Updated end to end tests to implement CompleteNavigation component in all use cases

github-actions[bot] commented 4 months ago

Browser bundle size

NPM build

	Package
Before	`180.09 kB`
After	`180.09 kB`
±	No change

CDN build

	Unminified	Minfied	Minified + gzipped
Before	`87.01 kB`	`32.72 kB`	`10.01 kB`
After	`87.01 kB`	`32.72 kB`	`10.01 kB`
±	No change	No change	No change

Code coverage

Coverage values did not change👌.

Total:

Lines	Branches	Functions	Statements
87.61%(+0.22%)	78.55%(+0%)	88.34%(+0%)	84.52%(+0.28%)

Generated against 5161e2fceb232c53bb7aaf893f2fb22ca04ad5aa on 18 March 2024 at 12:46:55 UTC