search

bugsnag / bugsnag-js-performance

Monitor the performance of your JavaScript (web and React Native) and see the results in your BugSnag dashboard.
https://docs.bugsnag.com/performance/integration-guides
MIT License
5 stars 3 forks source link

[PLAT-12475] Monkey patch notify method #474

Closed gingerbenw closed 4 months ago

gingerbenw commented 4 months ago

Goal

Refactor the error correlation implementation by patching the _notify method instead of leveraging addOnError to ensure callbacks run before the current span has closed

github-actions[bot] commented 4 months ago

Browser bundle size

NPM build

Package
Before 190.24 kB
After 191.13 kB
± +884 bytes ⚠️

CDN build

Unminified Minfied Minified + gzipped
Before 95.65 kB 35.92 kB 10.87 kB
After 96.10 kB 36.09 kB 10.91 kB
± +450 bytes ⚠️ +176 bytes ⚠️ +36 bytes ⚠️

Code coverage

Ok File (✨=New File) Lines Branches Functions Statements
✅ /home/runner/work/bugsnag-js-performance/bugsnag-js-performance/packages/core/lib/core.ts 100%
(+0%)		 91.66%
(+2.78%)		 92.85%
(+0%)		 98.3%
(+0.06%)

Total:

Lines Branches Functions Statements
87.11%(+0.02%) 78.46%(+0.09%) 87.96%(+0%) 83.89%(+0.01%)

Generated against 328ec7b5f0c76b560e00a9fbcead994a3de845d7 on 26 July 2024 at 08:23:04 UTC