Custom attribute limits - Githubissues

bugsnag / bugsnag-js-performance

Monitor the performance of your JavaScript (web and React Native) and see the results in your BugSnag dashboard.

https://docs.bugsnag.com/performance/integration-guides

MIT License

5 stars 3 forks source link

Custom attribute limits #508

Closed gingerbenw closed 1 month ago

gingerbenw commented 1 month ago

Goal

Add validation for custom span attributes

Changeset

Add new configuration options for attribute validation
Add new validation method for truncating string and array attributes based on configuration options
Add new validation method for dropping spans based on configuration options
Add logging for modified spans

Testing

Add unit tests for all attribute limits and behaviours

github-actions[bot] commented 1 month ago

Browser bundle size

NPM build

	Package
Before	`201.60 kB`
After	`209.68 kB`
±	`+8,082 bytes` ⚠️

CDN build

	Unminified	Minfied	Minified + gzipped
Before	`102.02 kB`	`37.66 kB`	`11.31 kB`
After	`106.97 kB`	`40.30 kB`	`11.84 kB`
±	`+4,958 bytes` ⚠️	`+2,640 bytes` ⚠️	`+526 bytes` ⚠️

Code coverage

Ok	File (✨=New File)	Lines	Branches	Functions	Statements
✅	/home/runner/work/bugsnag-js-performance/bugsnag-js-performance/packages/core/lib/attributes.ts	100% (+2.64%)	100% (+0%)	100% (+9.1%)	100% (+2.57%)
🔴	/home/runner/work/bugsnag-js-performance/bugsnag-js-performance/packages/core/lib/config.ts	72.97% (-5.81%)	63.88% (-21.3%)	41.66% (-13.89%)	73.68% (-5.73%)
✅	✨ /home/runner/work/bugsnag-js-performance/bugsnag-js-performance/packages/core/lib/custom-attribute-limits.ts	100% (+100%)	100% (+100%)	100% (+100%)	100% (+100%)
✅	/home/runner/work/bugsnag-js-performance/bugsnag-js-performance/packages/core/lib/span-factory.ts	100% (+1.17%)	100% (+0%)	100% (+11.12%)	100% (+1.17%)
🔴	/home/runner/work/bugsnag-js-performance/bugsnag-js-performance/packages/core/lib/span.ts	90.24% (-9.76%)	100% (+0%)	76.19% (-23.81%)	90.24% (-9.76%)
🔴	/home/runner/work/bugsnag-js-performance/bugsnag-js-performance/packages/platforms/browser/lib/auto-instrumentation/route-change-plugin.ts	88.88% (-7.12%)	75% (+0%)	53.84% (-23.93%)	89.28% (-6.87%)

Total:

Lines	Branches	Functions	Statements
87.83%(-0.15%)	78.58%(-0.62%)	86.8%(-1.42%)	85.97%(-0.08%)

Generated against 800dc7c3f523ee5ccbaff46aac9c4063f4689394 on 20 September 2024 at 15:40:39 UTC