search

bugsnag / bugsnag-php

BugSnag error monitoring and crash reporting tool for PHP apps
https://docs.bugsnag.com/platforms/php
MIT License
554 stars 77 forks source link

Add `ReturnTypeWillChange` to `Bugsnag\Breadcrumbs\Recorder` #630

Closed imjoehaines closed 3 years ago

imjoehaines commented 3 years ago

Goal

This suppresses a deprecation in PHP 8.1 which causes CI to fail, added by the "add return type declarations for internal methods" RFC

We may eventually need to avoid implementing Countable/Iterator in this class as it's not necessary and ReturnTypeWillChange may be removed at some point in the future. As that's technically a BC break (though one that is unlikely to affect anyone as this class is unlikely to be used externally) I've opted not to do that yet