bugsnag / bugsnag-react-native

Error monitoring and reporting tool for native exceptions and JS errors in React Native apps
https://docs.bugsnag.com/platforms/react-native
MIT License
370 stars 121 forks source link

Expose OOM config to javascript #412

Closed maxkomarychev closed 5 years ago

maxkomarychev commented 5 years ago

Native library has two options to control OOM reporting but they are not used in javascript side. https://docs.bugsnag.com/platforms/ios/configuration-options/#reportbackgroundooms https://docs.bugsnag.com/platforms/ios/configuration-options/#reportooms

Goal

Allow OOM-related configurations from js configuration.

Changeset

Tests

Discussion

Alternative Approaches

Outstanding Questions

Linked issues

Review

For the submitter, initial self-review:

For the pull request reviewer(s), this changeset has been reviewed for:

mattdyoung commented 5 years ago

Hi @maxkomarychev

Thanks for the PR, but I'm afraid we won't be able to merge it at this time.

We're in the process of making some significant improvements to bugsnag-react-native, including how options like this are initialized. The next major release will use a different approach to initialization so this problem won't exist.

For the time being we'd recommend following our instructions here for enhanced native integration which will allow you to configure the underlying iOS options: https://docs.bugsnag.com/platforms/react-native/react-native/enhanced-native-integration/#ios-native-installation