Error on types definitions

bugsnag / bugsnag-react-native

Error monitoring and reporting tool for native exceptions and JS errors in React Native apps

https://docs.bugsnag.com/platforms/react-native

MIT License

370 stars 121 forks source link

Error on types definitions #428

Closed neiker closed 4 years ago

neiker commented 4 years ago

On index.d.ts, BeforeSend is defined as (report: Report) => boolean | void; but in fact it receives 2 arguments. Correct signature: (report: Report, error: Error) => boolean | undefined;

mattdyoung commented 4 years ago

@neiker

Thanks for raising this, we'll look at fixing it in a future release.

mattdyoung commented 4 years ago

Fixed in v2.23.6