bugsnag / bugsnag-react-native

Error monitoring and reporting tool for native exceptions and JS errors in React Native apps
https://docs.bugsnag.com/platforms/react-native
MIT License
369 stars 121 forks source link

Fix packaging issue breaking compilation on RN <0.60 #441

Closed kattrali closed 4 years ago

kattrali commented 4 years ago

v2.23.3 updated bugsnag-cocoa to 5.22.10, which had the side effect of requiring an xcconfig file to compile the BugsnagStatic target. This target is used by RN projects on RN 0.59.x and earlier. This change adds the missing file to the manifest.

How did this happen?

For the v2.23.3 release, I did manual testing against RN 0.61 and expected the CI build to catch anything weird on <0.60, since it builds against an older project. However, the CI build was not running cleanly against the test project and passed where it should have failed. I've raised #440 to address this discrepancy.

How was this change tested?

Tested this change against projects running 0.59.10 and 0.61.5 as well as automating those tests in #440.

Related issues

Fixes #433

antoinerousseau commented 4 years ago

thanks!!