bugsnag / bugsnag-react-native

Error monitoring and reporting tool for native exceptions and JS errors in React Native apps
https://docs.bugsnag.com/platforms/react-native
MIT License
370 stars 121 forks source link

Run `pod spec lint` on CI #454

Closed rahul-malik closed 4 years ago

rahul-malik commented 4 years ago

Goal

Catch issues when changes have been made to BugsnagReactNative.podspec

Design

n/a

Changeset

Update test/test-react-native-pod-build.sh to include pod spec lint BugsnagReactNative.podspec before pod install

Added

Removed

N/A

Changed

Tests

N/A

Discussion

Alternative Approaches

Outstanding Questions

Linked issues

Review

For the submitter, initial self-review:

For the pull request reviewer(s), this changeset has been reviewed for:

xljones commented 4 years ago

Hey again @rahul-malik, thanks for this one too! As with #453 we'll review this one when priorities allow.

johnkiely1 commented 4 years ago

Hi @rahul-malik,

I am closing this PR as the Bugsnag react native library has now been moved to be incorporated into the bugsnag-js repository. I have raised a new issue capturing the intention of the PR and we will update as necessary on the new issue.