Files that shouldn't be in your npm package - Githubissues

bugsnag / bugsnag-react-native

Error monitoring and reporting tool for native exceptions and JS errors in React Native apps

https://docs.bugsnag.com/platforms/react-native

MIT License

370 stars 121 forks source link

Files that shouldn't be in your npm package #472

Closed halaei closed 4 years ago

halaei commented 4 years ago

Description

After installing bugsnag-react-native, there are some files in node_modules/bugsnag-react-native that really shouldn't be there.

Issue

Example of files and directories that should be removed:

android/.idea
android/local.properties (contains your local paths like ndk.dir=/Users/jamielynch/Library/Android/sdk/ndk-bundle)

Environment

Library versions:

├─ bugsnag-react-native@2.23.10
└─ react-native@0.63.2

cocoapods version (if any) (pod --version):
iOS/Android version(s):
simulator/emulator or physical device?:
debug mode or production?:
[ ] (iOS only) [BugsnagReactNative start] is present in the application:didFinishLaunchingWithOptions: method in your AppDelegate class?
[ ] (Android only) BugsnagReactNative.start(this) is present in the onCreate method of your MainApplication class?

Example Repo

[ ] Create a minimal repository that can reproduce the issue after running yarn install and react-native run-ios/react-native run-android
[ ] Link to it here:

Example code snippet

import { Client, Configuration } from 'bugsnag-react-native';

// (Insert code sample to reproduce the problem)

Error messages:

``` ```

xljones commented 4 years ago

Hi @halaei, we've just released an update to the React Native notifier which cleans up this issue. It now lives in the bugsnag-js monorepo, so the first new version of the React Native notifier is v7.3.0. Please note that this is a pretty major upgrade for this notifier, so you'll want to check out the UPGRADING.md file, as well as the docs. Closing the issue out as it's been resolved, but please let us know if you have any other comments!