bugsnag / bugsnag-ruby

BugSnag error monitoring & reporting software for rails, sinatra, rack and ruby
https://docs.bugsnag.com/platforms/ruby
MIT License
249 stars 174 forks source link

Mongo breadcrumb: Do not mask filter value nil #801

Open johnnyshields opened 1 year ago

johnnyshields commented 1 year ago

Goal

In Mongo queries, the value nil is a special in that it can impact the behavior of sparse indexes. Rather than masking it with "?" we should indicate that it is nil. There is no risk of this causing data leakage to the logs.

Design

This is implemented in the filter masking function.

Changeset

Only changes the Mongo breadcrumb functionality.

This also includes the changes from:

Testing

Tested in RSpec and by TableCheck in production.

mclack commented 1 year ago

Hi @johnnyshields

Thanks for raising this. Along with the other PRs you have put forward, we will take a look at this when time allows.