Fix compatibility with Ruby 3.4-dev

bugsnag / bugsnag-ruby

BugSnag error monitoring & reporting software for rails, sinatra, rack and ruby

https://docs.bugsnag.com/platforms/ruby

MIT License

249 stars 174 forks source link

Fix compatibility with Ruby 3.4-dev #815

Closed k0kubun closed 8 months ago

k0kubun commented 9 months ago

Goal

Parse backtraces correctly with Ruby 3.4-dev

Design

This PR deals with Ruby 3.4's backtrace incompatibility introduced at https://github.com/ruby/ruby/pull/9608. They used [`'] for fixing existing tests too.

Changeset

Fixed BACKTRACE_LINE_REGEX to parse backtraces which use two 's.

Testing

Reusing existing tests on Ruby 3.4-dev should be enough. Using this branch fixed our test cases.

clr182 commented 9 months ago

Hey @k0kubun

Thank you for reaching out and adding this PR. When priorities allow we will review this and look to merge. We will be sure to keep you updated here on this thread.