search

bugsnag / bugsnag-ruby

BugSnag error monitoring & reporting software for rails, sinatra, rack and ruby
https://docs.bugsnag.com/platforms/ruby
MIT License
246 stars 174 forks source link

Fix circular require warning #828

Closed imjoehaines closed 1 month ago

imjoehaines commented 1 month ago

Goal

This PR fixes a circular require warning caused by several files requiring the main bugsnag.rb file

I've also gone through and removed other duplicate requires, consolidating them into bugsnag.rb

See https://github.com/bugsnag/bugsnag-ruby/issues/822

tomlongridge commented 1 month ago

Is it worth considering a rake task to check for this in future?

imjoehaines commented 1 month ago

Is it worth considering a rake task to check for this in future?

I think the best approach would be to fail the Maze Runner tests if a warning is emitted. I've raised PLAT-12273 to track that work