search

bugsnag / bugsnag-symfony

BugSnag notifier for the Symfony PHP framework. Monitor and report errors in your Symfony apps.
https://docs.bugsnag.com/platforms/php/symfony
MIT License
43 stars 21 forks source link

Run Symfony's latest release on CI #110

Closed imjoehaines closed 4 years ago

imjoehaines commented 4 years ago

Goal

This PR adds a job to Travis which will fetch the latest published version of Symfony rather than a pre-defined version, including pre-release versions. For example, right now the latest version is v5.1.0-RC1. This is done using dvershinin/lastversion

We can now run master and next daily in order to alert us if an upcoming release will break this notifier

There are also a couple of changes in travis.yml that aren't totally related — we now cache Composer dependencies between runs to speed up builds, we run Symfony 4 on PHP 7.4 (a typo meant we didn't do this before) and I've added a composer show step to print the exact version we're testing:

$ composer show --direct
bugsnag/bugsnag                v3.21.0    Official Bugsnag notifier for PHP...
graham-campbell/testbench-core v1.1.2     TestBench Core Provides Some Test...
mockery/mockery                1.3.1      Mockery is a simple yet flexible ...
phpunit/phpunit                5.7.27     The PHP Unit Testing framework.
symfony/config                 v5.1.0-RC1 Symfony Config Component
symfony/console                v5.1.0-RC1 Symfony Console Component
symfony/dependency-injection   v5.1.0-RC1 Symfony DependencyInjection Compo...
symfony/http-foundation        v5.1.0-RC1 Symfony HttpFoundation Component
symfony/http-kernel            v5.1.0-RC1 Symfony HttpKernel Component
symfony/security-core          v5.1.0-RC1 Symfony Security Component - Core...
imjoehaines commented 4 years ago

From my perspective it would seem to make sense to script a lot of this out of the config file, however if this feels more maintainable by you @imjoehaines then I'm happy to approve.

I generally don't like putting CI specific things outside of the CI config file so it's easier to see what it's actually doing, but looking at this again today it's a bit of a mess!

I'll put it in a script :)

twometresteve commented 4 years ago

Happy to let @Cawllec lead on the approval of this, don't wait for mine.