Add PHP 8 to CI for Symfony 3.4, 4.4, 5 and pre-release versions
This required a small change to tests as PHP 8 introduces named arguments, which we are inadvertently using by calling ReflectionClass::newInstanceArgs. This calls the constructor by unpacking the given argument array and if that array has string keys, it now uses them as named arguments. Our array keys didn't quite match the actual argument names, so this errored without the change
Goal
Add PHP 8 to CI for Symfony 3.4, 4.4, 5 and pre-release versions
This required a small change to tests as PHP 8 introduces named arguments, which we are inadvertently using by calling
ReflectionClass::newInstanceArgs. This calls the constructor by unpacking the given argument array and if that array has string keys, it now uses them as named arguments. Our array keys didn't quite match the actual argument names, so this errored without the changeNo actual code changes were required