Closed niamzor closed 2 years ago
Hi @phillylovepark - thanks for the PR! We're looking to add a static analysis tool like psalm/phpstan to bugsnag-symfony at some point in the future. This should help fix deprecated error messages such as this. We'll review this PR as part of that work when priorities allow 👍
Hey @luke-belton! I really need this PR
hey @tarasTrujay - as this is a deprecation warning, it's not considered a critical fix for us at this time while we have other higher priority work on our backlog. I don't have an exact timescale for the static analysis changes I described in my comment above, however I will notify this thread with any updates. The deprecated change being warned about won't break until php 9.0 is released, which is still a long way off.
@luke-belton But you can merge this PR and that's it
Thanks for the PR @phillylovepark! I'm going to merge this down in https://github.com/bugsnag/bugsnag-symfony/pull/149 where I've added some unit tests for this class
I got a deprecated error when using
bugsnag-symfony
with PHP 8.1 :This is my first PR, so please tell me if something is not right.
Goal
Make
bugsnag-symfony
compatible with PHP 8.1.Changeset
It checks that
$haystack
is not null before usingstripos()
Testing
I ran phpunit tests