search

bugsnag / bugsnag-symfony

BugSnag notifier for the Symfony PHP framework. Monitor and report errors in your Symfony apps.
https://docs.bugsnag.com/platforms/php/symfony
MIT License
43 stars 21 forks source link

Handle WorkerMessageFailedEvent #89

Closed MatTheCat closed 3 years ago

MatTheCat commented 4 years ago

Goal

Fix #88

I don't know yet how to test this but I wanna be sure I've got the right approach.

rjharrison commented 4 years ago

Thanks for the code Mat. Looks good. I think we'd use notifyException() rather than notify(). We'll have a discussion internally about whether this is a feature that we want to add, and get back to you.

MatTheCat commented 4 years ago

Why would you wilfully ignore exceptions?

rjharrison commented 4 years ago

Why would you wilfully ignore exceptions?

We aim to report as much as possible. I think the question is more about how we do this, rather than if we want to do this. We will be investigating this further.