Add support for Symfony 5

bugsnag / bugsnag-symfony

BugSnag notifier for the Symfony PHP framework. Monitor and report errors in your Symfony apps.

https://docs.bugsnag.com/platforms/php/symfony

MIT License

43 stars 21 forks source link

Add support for Symfony 5 #92

Closed pyrech closed 4 years ago

pyrech commented 4 years ago

Ref #91

Two things were needed:

bypass the removal of the root_dir parameter and use the project_dir if available (a new parameter bugsnag.symfony_root was added);
add support for the new event classes.

I kept support for Symfony < 5 and Symfony >= 5.0 at the same time. I also added CI build for PHP 7.2 and PHP 7.3.

I also added an example application for Symfony 5.0.

pyrech commented 4 years ago

Hello @kattrali, can I have some feedback on this PR? We need Symfony 5 updates in several projects but are blocked because this bundle is not yet compatible.

It looks like the tests are failing on PHP 5 because of a memory limit...

mattdyoung commented 4 years ago

Hi @pyrech

We are actively working on testing this right now so we hope to be able to release in the near future.

Thanks!

pyrech commented 4 years ago

Thanks :pray: :heart_eyes:

Cawllec commented 4 years ago

Hi @pyrech, we've pulled it onto a branch and created a PR at #93, which we'll test, review, and merge as soon as we can.

Thanks for the contribution!