PLAT-10210 add windows support

bugsnag / bugsnag-unity-performance

Monitor the start-up, scene loading and network requests of your Unity game and see the results in your BugSnag dashboard.

https://docs.bugsnag.com/performance/integration-guides/unity

MIT License

1 stars 2 forks source link

PLAT-10210 add windows support #83

Closed richardelms closed 1 year ago

richardelms commented 1 year ago

Goal

Add windows build support for Unity Performance

Changeset

Added windows resource data
Added e2e testing setup

Testing

Covered by existing tests NOTE: the following tests are skipped due to flakyness that will be fixed in upcoming sprints: scene_load_spans: Load Scene By Name, Load Scene By Index persistence: P value response 0.0

bugsnagbot commented 1 year ago

Build size impact

Format	Size impact of Bugsnag (kB)
IL2CPP APK	4.1
IL2CPP IPA	1.88

Generated by :no_entry_sign: Danger

richardelms commented 1 year ago

CI aspects that have been made look fine to me, just unsure if there's enough testing added to back up the addition of WindowsNative.cs? Perhaps it's already covered by the existing e2e tests, now they are running on Windows?

Should there also be jobs added to the full pipeline to run tests on other Unity versions?

All resource attributes are covered by existing tests.

I have added 2020 and 2022 windows jobs to the full pipeline