search

bugsnag / bugsnag-unity

Automatic error reporting for Unity games
https://docs.bugsnag.com/platforms/unity
MIT License
89 stars 31 forks source link

Handle null status of client #788

Closed clr182 closed 2 months ago

clr182 commented 4 months ago

Goal

The client should not be null at this point.

Design

I've added an elvis operator to set application state of the client if it isn't null. I think that this might work to some degree, but it doesn't really handle the race condition. Might be better to add a less performative try/catch block instead. or check the client again to see whether it is null and return a log error.

Changeset

Added null checking operator. to SetApplicationState of client.

Testing

Manually

bugsnagbot commented 4 months ago

Build size impact

Format Size impact of Bugsnag (kB)
IL2CPP APK 2438.67
IL2CPP IPA 1497.97

Generated by :no_entry_sign: Danger