When a dSYM is uploaded, the API key should be included when making the call to the upload server. For all plugins and tools, we should try to do this by default if possible (by reading the Info.plist or via an environment variable).
Changeset
Changed
Updated 'Upload Bugsnag dSYM' build phase to first attempt to read the API key from a BUGSNAG_API_KEY environment variable and if not present, attempts to read the BugsnagAPIKey key from the Info.plist (assuming it is stored in the default location).
Tests
Manually tested by installing cocoapods plugin on a test project and checking that the dSYM was uploaded with the expected API key set for both scenarios (API key set in environment variable/Info.plist) on building/archiving the project.
Review
For the submitter, initial self-review:
[x] Commented on code changes inline explain the reasoning behind the approach
[ ] Reviewed the test cases added for completeness and possible points for discussion
[x] A changelog entry was added for the goal of this pull request
[x] Check the scope of the changeset - is everything in the diff required for the pull request?
This pull request is ready for:
[x] Initial review of the intended approach, not yet feature complete
[x] Structural review of the classes, functions, and properties modified
[x] Final review
For the pull request reviewer(s), this changeset has been reviewed for:
[ ] Consistency across platforms for structures or concepts added or modified
[ ] Consistency between the changeset and the goal stated above
[ ] Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
[ ] Usage friction - is the proposed change in usage cumbersome or complicated?
[ ] Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
[ ] Concurrency concerns - if components are accessed asynchronously, what issues will arise
[ ] Thoroughness of added tests and any missing edge cases
Goal
When a dSYM is uploaded, the API key should be included when making the call to the upload server. For all plugins and tools, we should try to do this by default if possible (by reading the
Info.plistor via an environment variable).Changeset
Changed
BUGSNAG_API_KEYenvironment variable and if not present, attempts to read theBugsnagAPIKeykey from theInfo.plist(assuming it is stored in the default location).Tests
Manually tested by installing cocoapods plugin on a test project and checking that the dSYM was uploaded with the expected API key set for both scenarios (API key set in environment variable/
Info.plist) on building/archiving the project.Review
For the submitter, initial self-review:
For the pull request reviewer(s), this changeset has been reviewed for: