search

bugsnag / webpack-bugsnag-plugins

Webpack plugins for common BugSnag actions.
MIT License
32 stars 29 forks source link

rush rebuild/build will return 1 instead of 0 although uploading source map successfully #65

Closed cqcmdwym closed 3 years ago

cqcmdwym commented 3 years ago

Describe the bug

Rush build/rebuild command which will trigger webpack build to uploading source map, although uploading successfully but command return 1 instead of 0. Run webpack command directly, everything is ok.

Steps to reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Environment

Example Repo

Example code snippet 

# (Insert code sample to reproduce the problem)
Error messages: ``` ==[ SUCCESS WITH WARNINGS: 1 project ]========================================= --[ WARNING: xxxxxxxx ]-------------------------[ 54.61 seconds ]-- [BugsnagSourceMapUploaderPlugin] uploading sourcemap for "*/x" Projects succeeded with warnings. ```
xljones commented 3 years ago

Hi @cqcmdwym 👋 do you have an output log from Rush and/or Webpack that shows what's happening here? Are you saying that the source maps upload as expected when run through Webpack directly, and indirectly through Rush? What's returning the 1 exit code? Is that @bugsnag/source-maps? If no errors are encountered, this tool returns an exit code of zero, so there may be something else in the build failing. Any further details you can provide should help use track this issue down 🙏

cqcmdwym commented 3 years ago

@xander-jones thanks for your reply, looks like a rush bug, once I set

infrastructureLogging: {
    level: 'none' // disable logging due to rush tool issue
  }

rush build return exit code 0 instead of 1.

xljones commented 3 years ago

Thanks for letting us know, although this may just mask the issue, and possibly hide other problems should they occur. If it's just a temporary workaround that should be okay.

Will close this out as it doesn't appear to be due to the Bugsnag plugin, but let us know if you encounter any issues with our library, and we'll investigate 👍