search

bugsnag / webpack-bugsnag-plugins

Webpack plugins for common BugSnag actions.
MIT License
32 stars 29 forks source link

Adding `metadata` to the README as a build argument #67

Closed charliegroll closed 3 years ago

charliegroll commented 3 years ago

Goal

metadata can contain important, free-form build information

Design

Types don't exist in this repo (I plan on adding them to https://github.com/DefinitelyTyped/DefinitelyTyped/blob/b9a1f5dcc0ce872829ee85e5c43c7f3e96970333/types/webpack-bugsnag-plugins/index.d.ts#L116

Changeset

The README now contains metadata as an accepted build argument

Testing

It works for our builds, so just add any k/v pair(s) to any build as metadata

johnkiely1 commented 3 years ago

Hi @charliegroll. Thanks for this. We will review shortly.

charliegroll commented 3 years ago

Thanks @johnkiely1 - I don't have any insights into why the build is failing... so you have access to the build logs/ability to retry it?

johnkiely1 commented 3 years ago

@charliegroll, we are looking into the failures now and will merge the PR in once we have them resolved.

johnkiely1 commented 3 years ago

Hey @charliegroll, if you pull the latest from next into your branch it should fix the build issues.

charliegroll commented 3 years ago

@johnkiely1 done - if you want a rebase lemme know