search

bugst / go-serial

A cross-platform serial library for go-lang.
BSD 3-Clause "New" or "Revised" License
617 stars 188 forks source link

darwin: use Go type wrappers to avoid declaring Go methods on C types. #163

Closed deadprogram closed 10 months ago

deadprogram commented 11 months ago

This is needed starting with Go 1.21 due to stricter enforcement of rules about adding methods to existing types, now including C types. It should fix #162

See https://github.com/golang/go/issues/60725 for further details.

deadprogram commented 11 months ago

cc @cmaglie :smile_cat:

deadprogram commented 11 months ago

Sorry to be a pest but Go 1.21 rc4 is now out, so probably the final release is coming anytime. Any chance to getting this reviewed, please? :smile_cat:

cmaglie commented 11 months ago

Hi @deadprogram

I've pushed more commits with the changes I proposed in this PR. I tested it and seems to work fine.

I'll keep the change here for a couple of days for you to check, and eventually merge them.

deadprogram commented 10 months ago

Thanks for the refinements @cmaglie at first glance it looks good. I will check it out in more detail this evening and get back to you.

deadprogram commented 10 months ago

Thank you for the additions @cmaglie let's merge and release please!

cmaglie commented 10 months ago

Here we go: https://github.com/bugst/go-serial/releases/tag/v1.6.0