bugst / go-serial

A cross-platform serial library for go-lang.
BSD 3-Clause "New" or "Revised" License
617 stars 188 forks source link

Switch to golang.org/x/sys/windows #179

Closed twpayne closed 1 week ago

twpayne commented 3 months ago

Describe the new feature or change suggestion

Firstly, thank you for this project!

Currently go.bug.st/serial has its own generated Windows syscalls in syscall_windows.go and zsyscall_windows.go. I recently opened a PR for golang.org/x/sys that adds the necessary calls: https://go-review.googlesource.com/c/sys/+/572295.

Once this is merged and released then go.bug.st/serial can switch to a more recent version of golang.org/x/sys and remove its generated code. I'm happy to open a PR to do this when the time comes.

Additional context

149 makes a similar change. Can #149 be merged too?

Issue checklist

twpayne commented 1 month ago

Closing due to inactivity.

cmaglie commented 1 week ago

@twpayne I'm sorry for the long delay in replying, unfortunately, I run this project in my free time, so issues may take very long to process.

I'll reopen this issue since it's a valid and valuable concern.