TravisCI usign go 1.7.x instead of 1.7.2

albenik commented 7 years ago

Yet another minor enhancement

cmaglie commented 7 years ago

I've merged the first commit 0eb640a.

About the second commit, I don't like the style used in golang, for two reasons:

moving //syscall altogether into syscall and renaming the current syscall to zsyscall seems kind of arbitrary to me... also why z? this change adds 4 new files just for the sake of keeping the //syscall declaration together
I would have accepted the above if the readability gain was substantial, but this doesn't seems the case because, at the moment, the //syscall are near the place where they are effectively used, I think it's a better place that gives more context to understand why those syscall are needed and how they are used. Actually moving them in another file seems to reduce readability IMHO (as well as adding 4 more file to the "mass" of code).

So, for now I'm closing this PR, BTW if you do not agree I'm happy to hear your opinion on that and discuss further.

albenik commented 7 years ago

@cmaglie First looks like I misunderstood gihub pull request behaviour. I created pull request only for the TravisCI commit. And plans to make a second pull request for //sys with explanation later. I made issue to discuss https://github.com/bugst/go-serial/issues/21

bugst / go-serial

TravisCI usign go 1.7.x instead of 1.7.2 #20