search

bugst / go-serial

A cross-platform serial library for go-lang.
BSD 3-Clause "New" or "Revised" License
620 stars 189 forks source link

vgo tags? #49

Closed silasb closed 4 years ago

silasb commented 6 years ago

Any plans to support vgo tags?

cmaglie commented 6 years ago

Hi @silasb, honestly I'm a bit out-of-the-loop here... is there a doc that explains what are vgo tags and how to use them?

silasb commented 6 years ago

Instead of doing versioning via package names you can now version via a git tag. I jumped the gun on this GH issue, there is no such thing as a vgo tag. It's just nicer to work with if there is a git tag. https://research.swtch.com/vgo-tour

cmaglie commented 6 years ago

Ok so, AFAIU, just tagging the current master as v1.0.0 should be enough right?

silasb commented 6 years ago

Yes.

cmaglie commented 5 years ago

It seems that also a go.mod file is required, I think I'll wait a bit more until a stable release of go tooling to see the best way forward.

maddie commented 5 years ago

Currently using vgo build in existing project with go-serial as dependency will fail with this error:

import "go.bug.st/serial.v1": cannot find module providing package go.bug.st/serial.v1

If I add the dependency manually to go.mod it will fail with below error:

go: go.bug.st/serial.v1@v0.0.0-20170728081230-eae1344f9f90: unrecognized import path "go.bug.st/serial.v1" (https fetch: Get https://go.bug.st/serial.v1?go-get=1: net/http: TLS handshake timeout)

I guess that's because vgo wasn't able to access that URL, but I don't really know how to fix this.

silasb commented 5 years ago

I fixed it via: https://github.com/silasb/betaflight-app/blob/master/go.mod

If the repo was tagged with a git version then I think it would be easier to work with.

—Silas

On Sun, Aug 19, 2018 at 10:29 PM, maddie notifications@github.com wrote:

Currently using vgo build in existing project with go-serial as dependency will fail with this error:

import "go.bug.st/serial.v1": cannot find module providing package go.bug.st/serial.v1

If I add the dependency manually to go.mod it will fail with below error:

go: go.bug.st/serial.v1@v0.0.0-20170728081230-eae1344f9f90: unrecognized import path "go.bug.st/serial.v1" (https fetch: Get https://go.bug.st/serial.v1?go-get=1: net/http: TLS handshake timeout)

I guess that's because vgo wasn't able to access that URL, but I don't really know how to fix this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bugst/go-serial/issues/49#issuecomment-414180559, or mute the thread https://github.com/notifications/unsubscribe-auth/AACe3k-ortf2cLA8f7H3c0DNw8A7tARJks5uSh7wgaJpZM4UJnyD .

cmaglie commented 4 years ago

go mod is now supported with the import go.bug.st/serial.