search

bugst / go-serial

A cross-platform serial library for go-lang.
BSD 3-Clause "New" or "Revised" License
658 stars 200 forks source link

Works on FreeBSD (even on armv6 and armv7 when cross compiled). #7

Closed fbettag closed 8 years ago

fbettag commented 8 years ago

i just copied darwin stuff :)

cmaglie commented 8 years ago

thanks for your conribution @fbettag !

would you like to try also the version listed here https://github.com/bugst/go-serial/tree/v1 ? I've refactored the API to be more go-lang style, but since this is a breaking change it forced me to change the import from

go.bug.st/serial

to

go.bug.st/serial.v1

so you can keep both side-by-side. My plan is to switch development to v1 soon (the old version will be marked v0 and will continue to be available on the old import).

fbettag commented 8 years ago

No problems! I needed it for a side project :)

Well since i just copied _darwin to _freebsd, i’m sure you can do this easier than me forking and opening a PR :P

Thanks for the great library!

On 19 Sep 2016, at 11:03, Cristian Maglie notifications@github.com wrote:

thanks for your conribution @fbettag https://github.com/fbettag !

would you like to try also the version listed here https://github.com/bugst/go-serial/tree/v1 https://github.com/bugst/go-serial/tree/v1 ? I've refactored the API to be more go-lang style, but since this is a breaking change it forced me to change the import from

go.bug.st/serial

to

go.bug.st/serial.v1

so you can keep both side-by-side. My plan is to switch development to v1 soon (the old version will be marked v0 and will continue to be available on the old import).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bugst/go-serial/pull/7#issuecomment-247942778, or mute the thread https://github.com/notifications/unsubscribe-auth/AAE4LrIeH05dkhasK3BQYW2AFaWCNTfvks5qrk_GgaJpZM4J-C99.

cmaglie commented 8 years ago

Well since i just copied _darwin to _freebsd, i’m sure you can do this easier than me forking and opening a PR :P

yes I did it already:

https://github.com/bugst/go-serial/commit/85dc492d831a32c6f0fe4be8762c9a034226eb6e

but I've no freebsd box at hand so my request was just to test it :-)

fbettag commented 8 years ago

Oh sorry, i’ll give it a shot later today!

On 19 Sep 2016, at 12:04, Cristian Maglie notifications@github.com wrote:

Well since i just copied _darwin to _freebsd, i’m sure you can do this easier than me forking and opening a PR :P

yes I did it already:

85dc492 https://github.com/bugst/go-serial/commit/85dc492d831a32c6f0fe4be8762c9a034226eb6e but I've no freebsd box at hand so my request was just to test it :-)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bugst/go-serial/pull/7#issuecomment-247954623, or mute the thread https://github.com/notifications/unsubscribe-auth/AAE4Lr0FOO8ERydrIre-LDmqkwPKvcmvks5qrl46gaJpZM4J-C99.

fbettag commented 8 years ago

Just tested .v1 on FreeBSD 10.3-RELEASE and cross compiled with go 1.7 and GOARM=6 GOARCH=arm GOOS=freebsd and works perfectly :)

On 19 Sep 2016, at 12:45, Franz Bettag franz@bett.ag wrote:

Oh sorry, i’ll give it a shot later today!

On 19 Sep 2016, at 12:04, Cristian Maglie <notifications@github.com mailto:notifications@github.com> wrote:

Well since i just copied _darwin to _freebsd, i’m sure you can do this easier than me forking and opening a PR :P

yes I did it already:

85dc492 https://github.com/bugst/go-serial/commit/85dc492d831a32c6f0fe4be8762c9a034226eb6e but I've no freebsd box at hand so my request was just to test it :-)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bugst/go-serial/pull/7#issuecomment-247954623, or mute the thread https://github.com/notifications/unsubscribe-auth/AAE4Lr0FOO8ERydrIre-LDmqkwPKvcmvks5qrl46gaJpZM4J-C99.