search

bugthesystem / Autofac.Extras.NLog

An Autofac module to integrate Autofac and NLog, it supports both constructor and property injection.
MIT License
50 stars 18 forks source link

NLogger.Trace not implemented #2

Closed Holf closed 10 years ago

Holf commented 10 years ago

All the standard Log Levels are represented, except 'Trace'. In other words, when using this module, you can do: _logger.Debug("My debug message");

But you cannot do: _logger.Trace("My trace message");

Why is this? I can happily fix and do a pull request, if you like.

bugthesystem commented 10 years ago

Hi @Holf , thanks for your feedback, I think i missed it. It would be nice.

Holf commented 10 years ago

Done, and I've issued a Pull Request. It's a really nice module; been using it a lot recently, so thanks!

It would be great if you could do a new NuGet release if you accept the Pull Request. :-)

Holf commented 10 years ago

I didn't bump the AssemblyVersion... didn't want to interfere with any versioning strategy that you might have (i.e. would a change such as this be '1.2.1' or '1.3.0'?).

bugthesystem commented 10 years ago

Thanks @Holf , I published new version of package.

Holf commented 10 years ago

Fantastic! Thank you.