bugthesystem / Autofac.Extras.NLog

An Autofac module to integrate Autofac and NLog, it supports both constructor and property injection.
MIT License
50 stars 18 forks source link

Release new version #21

Open 304NotModified opened 5 years ago

304NotModified commented 5 years ago

Please release a new version on nuget.

After #10, #15 and #19 it could really use a new release :)

eXpl0it3r commented 5 years ago

I second this!

304NotModified commented 5 years ago

Polite bump @ziyasal

CNBoland commented 5 years ago

I posted a new package version 2.0.0-rc.

304NotModified commented 5 years ago

@eXpl0it3r could you confirm that v2 is working correctly?

LordPinhead commented 5 years ago

Cant say that scope resolving works for me:

    public void ResolveNLogger() {
        var builder = new Autofac.ContainerBuilder();
        builder.RegisterModule<NLogModule>();
        builder.RegisterType<Testclass>();
        var container = builder.Build();
        var scope = container.BeginLifetimeScope();
        var logger = scope.Resolve<ILogger>(); // Not Found
    }
eXpl0it3r commented 5 years ago

2.0.0-rc works for me

Never mind, it actually doesn't work, as it still depends on an old version of Autofac. Can't we have this connection loosen, so it's not fixed to one specific version?

CNBoland commented 3 years ago

@eXpl0it3r @LordPinhead @304NotModified Can you verify your project with current version of the NuGet package? v3.x supports Autofac 5.x. v4.x supports Autofac 6.x.