search

bugthesystem / Autofac.Extras.NLog

An Autofac module to integrate Autofac and NLog, it supports both constructor and property injection.
MIT License
50 stars 18 forks source link

v1.2.2 causes code analysis error #4

Closed ThreeScreenStudios closed 9 years ago

ThreeScreenStudios commented 9 years ago

Hi,

First off, thanks for making this library, it's been very valuable in integrating Autofac to my existing project with NLog. I upgraded to 1.2.2 via Nuget today, and have gotten the following error when building my solution:

CA0001 Error Running Code Analysis CA0001 : Could not find type 'NLog.LoggerReconfiguredDelegate' in assembly 'Autofac.Extras.NLog, Version=1.2.2.0, Culture=neutral'. Errors and Warnings

I was wondering if there was any troubleshooting you'd suggest to fix this, or should I just rollback to 1.2.1 for now? Thanks!

bugthesystem commented 9 years ago

Hi, Thanks @ThreeScreenStudios your feedback. I try tried reproduce error in VS2015 and I didn't get any error. Can you share more detail if you have? I will look for a solution.

ThreeScreenStudios commented 9 years ago

Hi @ziyasal - sure, I will try to get more repro info (I'm using VS2013 update 4), and get back to you.

janv8000 commented 9 years ago

I think this is related to #5 , LoggerReconfiguredDelegate was removed in NLog 2.0

image

bugthesystem commented 9 years ago

I agree with @janv8000 I think #6 solves this issue

bugthesystem commented 9 years ago

Pushed new version 1.2.3

ThreeScreenStudios commented 9 years ago

Sorry ziyasal, I totally dropped the ball on getting you a repro - glad janv8000 was able to help though! I just updated to 1.2.3 and it builds successfully - much appreciated.

bugthesystem commented 9 years ago

@ThreeScreenStudios Nope ;) All is well now.