Unfortune method to log exception

bugthesystem / Autofac.Extras.NLog

An Autofac module to integrate Autofac and NLog, it supports both constructor and property injection.

MIT License

50 stars 18 forks source link

Unfortune method to log exception #9

Open rosieks opened 8 years ago

rosieks commented 8 years ago

ILogger interface has unfortune method void Error([Localizable(false)] string message, Exception exception). It's fine when I pass Exception class, but when I pass any other exception C# compiler choose different method to use: void Error<TArgument>([Localizable(false)] string message, TArgument argument).

The effect is that exception details are not logged. I suggest to change order of parameters and deprecate original method.

shoftee commented 7 years ago

I've opened #15 regarding this issue, but the author is not responding :<

bugthesystem commented 7 years ago

Hi @all sorry for late response, it is merged and will be pushed soon, @shoftee thanks for your contribution 👍

304NotModified commented 5 years ago

I think this could be closed with the release of 2.0.0-rc

CNBoland commented 3 years ago

@rosieks @shoftee @304NotModified Can you verify its working now in your projects with current versions of the NuGet packages?