search

bugthesystem / FireSharp

An asynchronous cross-platform .Net library for Firebase
The Unlicense
698 stars 147 forks source link

[Proposal] Firebase 3 compatibility, remove users management functions #50

Open moonpyk opened 8 years ago

moonpyk commented 8 years ago

Since firebase 3, the way of managing the users definitively changed, the API endpoints have vanished, it seems that the API has never been made public and got reverse engineered from Node SDK source code.

In my humble opinion, we should remove the entry points to those undocumented APIs moreover they won't work for new projects, until Google makes a move on those points Fire# should not give the false impression that user management is available.

What are your thoughts on this ?

bugthesystem commented 8 years ago

hi @moonpyk I havent find a time to check v3 changes. I agree with you, we can remove them from Fire# IMO. These changes came with a pull request #22 by @tillerstarredwards. Maybe they need these methods and we can document user management API implementations with warning or move them to other client implementation and then document it with warning.

If everybody is happy to remove them, we can do then.

tillerstarredwards commented 8 years ago

We added these so that we could do user management from C#. We have a project that is using this that we won't want to migrate to firebase v3 until there is this sort of functionality. The UI in V2 was not feasible for managing 25k users. I'm cool with deprecating the functions and moving them towards end of life...

moonpyk commented 8 years ago

Oki, I'll adress a PR doing that.

For now, I think that user management would be a great feature to add, but needs to go in another assembly (allowing to pull supplementary dependencies), the core functionality should stay portable.