bugthesystem / FireSharp

An asynchronous cross-platform .Net library for Firebase
The Unlicense
696 stars 147 forks source link

Incompatible with .Net Core #56

Closed doczoidberg closed 7 years ago

doczoidberg commented 8 years ago

Package FireSharp 2.0.4 is not compatible with netcoreapp1.0 (.NETCoreApp,Version=v1.0). Package FireSharp 2.0.4

Will there be compatiblity with the new .Net core?

himadrinath commented 8 years ago

@ziyasal when it well be available for .net core 1.0 ..........

dcworldwide commented 8 years ago

This will be huge for my company! Please advise if .net core support is in the works 👍

dcworldwide commented 8 years ago

What is actually involved in porting to .net core? Is it a huge amount of work?

bugthesystem commented 8 years ago

Hey @all it is actually in my road map but I am so busy nowadays both personal life and job side. So, It might be delay to make it available. Thank you!

ubirajaramnj commented 8 years ago

Hi ziyasal,

can I contribute make it compatible with .Net Core?

sandcastle commented 7 years ago

@ziyasal any update on others providing help or your ETA to update?

bugthesystem commented 7 years ago

hi @all It would be good to see that someone working on this, IMO it shouldn't be huge amount of work but I haven't find a time to work on.

jazpearson commented 7 years ago

I've just submitted a PR for this (#76). There's a bit of work to do to tidy it up, but it should be a pretty good start. Converting the firesharp project was very simple. The unit tests are what took most of the time (and there's 1 failing).

jviaches commented 7 years ago

Support for .NET Core would be great :)

doczoidberg commented 7 years ago

works with .NET Core 2.0!

bugthesystem commented 7 years ago

:+1: cool!

himadrinath commented 7 years ago

NuGet not updated yet.....................

doczoidberg commented 7 years ago

you need .NET core 2.0. It supports more libraries than 1.1

himadrinath commented 7 years ago

i already have 2.0

doczoidberg commented 7 years ago

it should work with the nuget package. It does for me