bugy / script-server

Web UI for your scripts with execution management
Other
1.57k stars 248 forks source link

runner does not appear in GUI when working_directory ends with slash #522

Closed RollingHog closed 1 year ago

RollingHog commented 2 years ago

Replication:

Proposal:

I can try to implement first or second solution as soon as repo owner choose which one is preferable

bugy commented 2 years ago

Hi @RollingHog, I'm not 100% sure if I understand it. Is it json parsing error or some other error on script server side? Because if it's json error, then the json file is corrupted and should be formatted properly with json

RollingHog commented 2 years ago

Sorry, will try to clarify. You see, this file

{
  "script_path": "docker-compose up -d",
  "working_directory": "/home/dp/Desktop/backend"
}

appears in web GUI left panel properly; but this file (which only difference is trailing slash / in working_directory key) doesn't:

{
  "script_path": "docker-compose up -d",
  "working_directory": "/home/dp/Desktop/backend/"
}

My system is (L)ubuntu in case it matters.

bugy commented 2 years ago

And which error do you see in server logs?

RollingHog commented 2 years ago

I must apologize. Error does not replicate, logs are clear. I'm not sure why I didn't see scripts but looks like it was not because of trailing slash. I'll try to replicate it later with fresher head, but looks like it doesn't cause the problem.

upd: but trailing slash makes it think that its a network adress, still no good, but not connected to this issue