bugy / script-server

Web UI for your scripts with execution management
Other
1.57k stars 248 forks source link

summer time change #545

Open baniczar opened 2 years ago

baniczar commented 2 years ago

I'm using script-server few months already and I can say I'm impressed. Great job!

Last Sunday we had a summer time changed. I'm located in CEST timezone. My test were scheduled to run at 14:00 After the time change scheduler is running the script at 15:00

From the Linux OS perspective everything looks OK. Timezone is set correctly, current timezone time was correctly changed, UTC time is correct. If I run the script manually the log have correct run time

Only the scheduled runs are shifted by 1 hour. Before the time change (Winter time UTC +1) when I scheduled the script to 14:00 I noticed that in the schedule file it was set as 13:00. Looks like you keep the UTC time in the scheduler config files.

Now after the time change the script is running at 15:00 instead of 14:00

As a workaround I can try to remove the schedule and do it one more time but I thought to correct it the right way and not have same issue with the next time change. Can you help me troubleshoot that?

bugy commented 2 years ago

Hi @baniczar, thanks for reporting! Is it one-time or repeated schedule?

baniczar commented 2 years ago

Hi @bugy, it's repeated schedule configured before the time change

bugy commented 2 years ago

Hi @baniczar I'll try to work on it in the nearest days

bugy commented 2 years ago

I tried to fix it, but then I realized, that Script server should use a user's timezone (not a server timezone). Which would require more work :(

baniczar commented 2 years ago

Understood. I already handled that by modifying the schedule files. I just need to remember to change that in half a year. Thanks!