search

bugy / script-server

Web UI for your scripts with execution management
Other
1.59k stars 247 forks source link

Delete Script from frontend #641

Closed EduardSchwarzkopf closed 1 year ago

EduardSchwarzkopf commented 1 year ago 
          Hi @mgfjx, unfortunately this is not possible via UI

You can delete config files in conf/runners folder

Originally posted by @bugy in https://github.com/bugy/script-server/issues/464#issuecomment-864361885

Regarding this comment, why is that not possible?

bugy commented 1 year ago

Hi @EduardSchwarzkopf, what do you mean exactly?

EduardSchwarzkopf commented 1 year ago

Why it is not possible to delete scripts from the UI?

bugy commented 1 year ago

Because this feature is not implemented

EduardSchwarzkopf commented 1 year ago

yes, I know, but technically it is possible to implement, right?

bugy commented 1 year ago

Yes of course

Eduard Schwarzkopf @.***> schrieb am Di., 28. März 2023, 19:48:

yes, I know, but technically it is possible to implement, right?

— Reply to this email directly, view it on GitHub https://github.com/bugy/script-server/issues/641#issuecomment-1487356257, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJXPJKRCERWEO7SAV2KSWTW6MP7NANCNFSM6AAAAAAWCKGPTA . You are receiving this because you were mentioned.Message ID: @.***>

EduardSchwarzkopf commented 1 year ago

Is there a contribution guideline? I'd like to add this feature

EduardSchwarzkopf commented 1 year ago

ok found it. Now the question is, how should the solution look like? I thought of an icon here, probably the trash-bin icon: grafik

bugy commented 1 year ago

Hey

Is there a contribution guideline?

Unfortunately no. You can ask any questions, i could help with them

Now the question is, how should the solution look like?

May be we should add it to a script configuration page? To prevent an unintended click in the table

Also, I'm not sure about permanent deletion. May be we could move it "to archive"? E.g. conf/deleted folder, and change prefix to .json.deleted. In this case it will be easier to revert unintended deletion My point is, that some script configurations are very complex, so deleting it by accident might be super annoying

What do you think?

EduardSchwarzkopf commented 1 year ago

yeah, totally valid points. Where do you think would be the best place for that button?

bugy commented 1 year ago

May be at the very bottom, left side?

EduardSchwarzkopf commented 1 year ago

sounds good. Not worked that much with vue before, but let's see how i can get this done :D

bugy commented 1 year ago

I'm closing this one as a duplicate of https://github.com/bugy/script-server/issues/464