included configs allow yaml

[yosefy]

for now i see that i can't include yaml conf as in logs it try to parse it as json is it possible to include yaml too?

thanks

[MNeill73]

This would be a bad idea.

Config files for WhateverProduct should accept a single syntax. JSON, or YAML, or INI file, or whatever... But one format. A config file that allows multiple syntaxes is just asking for config to break all over the place.

On Tue, Nov 21, 2023, 9:55 PM yosefy @.***> wrote:

for now i see that i can't include yaml conf as in logs it try to parse it as json is it possible to include yaml too?

thanks

— Reply to this email directly, view it on GitHub https://github.com/bugy/script-server/issues/721, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3HBI3SRPXEVUQXUTJBECT3YFVSRRAVCNFSM6AAAAAA7VQ5QP6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGAYDKNBWG42TAMY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[yosefy]

yes but main script is yaml, but included can be only json so it is exactly the state now MNeill73

[bugy]

Good point @yosefy, I guess we missed this scenario, when added support for yaml files.

[bugy]

@MNeill73 thanks for sharing the feedback. As @yosefy said, yaml files are already supported, so allowing them in include seems logical. The thing is, that many script server users (admins) are not very technical, and even learning json format is a struggle for some of them. So if they already know yaml, I think it's better to make script server a bit more user friendly for them. Though you have a good concern

[yosefy]

thanks bugy

also, can we just may be allow yaml in main config too?

not urgent at all but to be consistent

also it is pain, that there are no comments in json :)

[bugy]

@yosefy what do you mean "in main config" ?

also it is pain, that there are no comments in json :)

I think you can use comments in script server json. #415

[yosefy]

main is the runner the main one that includes the rest

On Mon, Nov 27, 2023 at 12:37 PM Iaroslav Shepilov @.***> wrote:

@yosefy https://github.com/yosefy what do you mean "in main config" ?

also it is pain, that there are no comments in json :)

I think you can use comments in script server json. #415 https://github.com/bugy/script-server/pull/415

— Reply to this email directly, view it on GitHub https://github.com/bugy/script-server/issues/721#issuecomment-1827572839, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADCXF3MLFJERATZJRGORENDYGRUNBAVCNFSM6AAAAAA7VQ5QP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRXGU3TEOBTHE . You are receiving this because you were mentioned.Message ID: @.***>