search

bugzinga / sql-hunting-dog

Quick Search Tool (AddIn) for Microsoft SQL Management Studio
http://www.sql-hunting-dog.com
Other
36 stars 18 forks source link

Possibility to hide Add in window after action #1

Closed csbubbles closed 7 years ago

csbubbles commented 7 years ago

@FastNinja I've moved the PR from Bitbucket to GitHub. So you could approve it and merge if needed. It would be nice if you integrated that CI you are using with the code reviews, so it wouldn't let merge if the build for the PR fails.

@pstraszak We've moved from Bitbucket to GitHub, I sent you a request to add you to "collaborators" here if you are okay with it.

+ @gusarov + @greinerk

FastNinja commented 7 years ago

@csbubbles oh Thanks a lot you copied it across!

FastNinja commented 7 years ago

Awesome job. I have integrated CI !

On 21 May 2017 at 02:24, Maxim Novikov notifications@github.com wrote:

@FastNinja https://github.com/fastninja I've moved the PR from Bitbucket to GitHub. So you could approve it and merge if needed. It would be nice if you integrated that CI you are using with the code reviews, so it wouldn't let merge if the build for the PR fails.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bugzinga/sql-hunting-dog/pull/1#issuecomment-302883337, or mute the thread https://github.com/notifications/unsubscribe-auth/ANClYsvkFzpMHJ8HHN0nadidczfOp7WPks5r7xOpgaJpZM4NhV9u .

csbubbles commented 7 years ago

@FastNinja You'd rather remove your commit with modified Connect.cs, and merge the pull request. As your fix is not related to this review. And then create another PR with the fix. Otherwise, you kind of mix things up and create sort of a mess.

Update: Sorry, it looks like the PR can't get through without that change as that file's encoding was changed in it somehow.

csbubbles commented 7 years ago

@FastNinja Okay, fixed. Please proceed with the merge if the change looks okay.

FastNinja commented 7 years ago

@csbubbles let me check if that works as intended. I will take MSI from appveryer then install it and verify the functionality...