bugzmanov / nes_ebook

A mini book on writing NES emulator using rust lang
https://bugzmanov.github.io/nes_ebook/index.html
385 stars 68 forks source link

Fix undefined variable in ch3.1 #6

Closed nmarley closed 3 years ago

nmarley commented 3 years ago

Hi, thanks for the great ebook!

I was going thru the tutorial sequentially and found a couple places in Chapter 3.1 where checking for result == 0, but the variable hadn't been introduced yet at that point. Later they are refactored out, but for others going thru this sequentially it might be a bit confusing. I thought I'd open this and maybe it can help others too.

Thanks!

bugzmanov commented 3 years ago

Hey @nmarley ! Thank you for noticing and doing this! I was off the grid for a little bit. Will integrate your changes today