buidl-bitcoin / buidl-python

python3 bitcoin library with no dependencies and extensive test coverage
https://pypi.org/project/buidl/
MIT License
83 stars 26 forks source link

Change taproot functions #153

Closed jimmysong closed 1 year ago

jimmysong commented 1 year ago

bip340 was not very descriptive, so that was changed to be xonly The idea of a tweak was not very clear, instead the merkle root of the script path is a lot easier to reason about, so the code reflects this change. The terminology of internal pubkey and external pubkey is used to make it conceptually simpler. Similarly, a Tap Root is also not very clear, so we now use methods of a public key or a tapleaf/tapbranch to construct the needed external public keys and control blocks.

mflaxman commented 1 year ago

Nice @jimmysong!