buidl-labs / livepeer-pricing-tool

A tool for enhancing the price visibility in livepeer ecosystem.
http://livepeer-pricingtool.surge.sh/
4 stars 2 forks source link

Stale pricing data for orchestrator #21

Open adamsoffer opened 3 years ago

adamsoffer commented 3 years ago

I noticed the price per pixel for this orchestrator hasn't updated since July. Any idea why?

https://livepeer-pricing-tool.com/priceHistory/0xda43d85b8d419a9c51bbf0089c9bd5169c23f2f9

adamsoffer commented 3 years ago

cc @Saumay-Agrawal

Saumay-Agrawal commented 3 years ago

Hi @adamsoffer, I just downloaded the lpdb.sqlite3 file from the broadcaster node we are running to check for any data inconsistency. However, the current price per pixel value for this orchestrator coincides with what we are getting in our broadcaster node.

Maybe the orchestrator has been inactive all this time?

adamsoffer commented 3 years ago

Hm that orchestrator is active and belongs to Bison Trails which is the #1 orchestrator by stake. I confirmed with them they changed their price per pixel a few weeks ago, though even if they hadn't the price should change due to gas prices.

adamsoffer commented 3 years ago

Maybe an issue with the broadcaster? Will run this by Yondon and Nico.

adamsoffer commented 3 years ago

From Nico:

I checked some other O's though and they don't have an updated price either. Perhaps insufficient reserve to be able to cache prices on their B node ? Their B node logs would be interesting here

Could you share your broadcaster logs @Saumay-Agrawal? Thanks!

adamsoffer commented 3 years ago

This appears to still be an issue. This price hasn't changed https://livepeer-pricing-tool.com/priceHistory/0x21d1130dc36958db75fbb0e5a9e3e5f5680238ff

Saumay-Agrawal commented 3 years ago

@adamsoffer I restarted the broadcaster node, but nothing happened unlike the previous time (https://discord.com/channels/423160867534929930/426114749370204170/797188011716640829). It seems like the broadcaster node is fetching (or mis-fetching for that matter) the wrong values for some reason.

Can you tell what price per pixel value is being shown by a broadcaster running at your side?

adamsoffer commented 3 years ago

@Saumay-Agrawal Sure. Can you remind me what the minimum deposit and reserve I need to fund my broadcaster with for fetching orchestrator prices?

Saumay-Agrawal commented 3 years ago

Based on Nico's suggestion we have kept 1 ETH in reserve. But this might be outdated as this amount was suggested by him while we were in the development phase of the pricing tool, and there has been a surge since then. So I think Nico would be the best person to answer this question.

adamsoffer commented 3 years ago

I believe the orchestrators with stale data are due to "insufficient sender reserve" errors being returned to the broadcaster. See this orchestrator which still has a stale price. I think we need to increase our reserve even more. I need to find out by how much.