search

buidl-labs / livepeer-pricing-tool

A tool for enhancing the price visibility in livepeer ecosystem.
http://livepeer-pricingtool.surge.sh/
4 stars 2 forks source link

Use a JS style guide #9

Open prastut opened 4 years ago

prastut commented 4 years ago

Recommended: JS: https://github.com/airbnb/javascript JSX/React: https://github.com/airbnb/javascript/tree/master/react

All you need to do is install this and then let the compiler tell you all the fixing that needs to be done.

Saumay-Agrawal commented 4 years ago

I installed this guide but didn't get any highlights for fixing.

Is this a generic recommendation, or was it based out of some part of code? If the latter is the case, could you provide a link to that specific part of code?

prastut commented 4 years ago

@Saumay-Agrawal probably missing out some step in installation. If it works right, then your console is full of warnings of wherever best practises are not met inside your code.

Saumay-Agrawal commented 4 years ago

Following this article: https://medium.com/@samailabalap/setting-up-eslint-on-vs-code-with-airbnb-javascript-style-guide-4d9936897f03

Other articles also feature the same steps. Can you identify is something is amiss?

prastut commented 4 years ago

@Saumay-Agrawal deprioritize this. good to have issues can be addressed in the end.