search

buigiaanfb1 / extract-data

0 stars 0 forks source link

Start of the code review process 👋 #18

Open olivierobert opened 2 years ago

olivierobert commented 2 years ago

Hello An 👋 , thank you for your effort on the code submission. This is Olivier (again 😉) from Nimble, and I am happy to be the reviewer for our code review session.

During the review process, I would like to know more about your decisions, and thus I will create issues where I think there could be more improvements regarding your performance here.

At the same time, please keep in mind that this is a bi-directional process, and I would love to hear back from you as well. Therefore, do not hesitate to raise your questions or share your opinions about the implementation (if any) during the process.

If we are aligned on any issue, and you would like to correct them, please address the issue using a proper git flow (creating a new branch, opening a Pull Request (PR) per issue, and merging the code when you are ready), and I will follow up on those fixes. Please note that you don't have to close any of my created issues after merging your PRs, I will help verify and close them for you once they pass. 😇

We expect the code review process to be completed within 2-3 days. As a result, ensure you are responsive during this process. If you need additional time, please inform us immediately so we can plan accordingly.

In the end, I do hope that you find the process enjoyable. Good luck and happy coding. 🤘

olivierobert commented 2 years ago

@buigiaanfb1 I completed the first round of reviews. The major concern is #19, as it encompasses all parts of the application, but I would love to get your feedback on all open issues.

In this code review process, we aim to focus on key core areas. The goal is not to challenge you on every part of your submission, as this would the length of the recruitment process, but to simulate how we could work together as part of a code review process.

buigiaanfb1 commented 2 years ago

@olivierobert Thank you so much for spending your time reviewing my code. I understand that we will work together at this time to solve and improve our code to make it better. In the next hour, I will start fixing and answering you based on your raised issues.

olivierobert commented 2 years ago

Thank you @buigiaanfb1 for the feedback and additional pull requests.

As explained previously, it is now time for us to wrap up this stage of the recruitment process as we aim to keep the whole process not too long for all parties involved. We have gathered enough information for us to make a decision on the next steps.

Thank you for your efforts thus far, we deep,y appreciate it. We understand that applying to a company takes a lot of effort. Thank you again 🙇