search

build-canaries / clj-cctray

:vertical_traffic_light: Clojure cctray.xml parser
http://build-canaries.github.io/clj-cctray/
Eclipse Public License 1.0
2 stars 1 forks source link

Remove all the http specific code and only parse strings or streams #11

Closed GentlemanHal closed 9 years ago

GentlemanHal commented 9 years ago

@cowley05 @joejag

I was thinking, should loading of the cctray xml file be done by this library?

We could just take either a stream or a string that is the loaded xml file and then pass it into a map. This would make this library simpler as it would no longer have to worry about issues with things like https or timeouts. This would also allow developers to use their libs of choice for actually loading the xml from files or urls.

Thoughts?

joejag commented 9 years ago

+1 I felt dirty watching the dependencies come down after adding clj-http. It fixed the issue we had at the time, but it'd adding a coupling.

I'd say remove it, and update the README to show an example of how to use the library which also happens to use clj-http

GentlemanHal commented 9 years ago

Ok cool, I'm going to change this issue to remove the http stuff.

GentlemanHal commented 9 years ago

@joejag Rather than adding an example to the readme I'll update Nevergreen and link to that as an example of this library being used in a real project.

joejag commented 9 years ago

It appears we can communicate in Github via selfies. So @GentlemanHal my response is:

selfie-0

GentlemanHal commented 9 years ago

@joejag Haha, right-o! I'm going to close this then as I've removed the reader namespace with my last commit.